feat: filter schemas by name #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt2e
requested review from
alecthomas,
dhanji,
wesbillman and
worstell
as code owners
Open
alecthomas
reviewed
Mar 25, 2024
cmd/ftl/cmd_schema.go
Outdated
| @@ -1,7 +1,7 @@ | |||
| package main | |||
|
|
|||
| type schemaCmd struct { | |||
| Get getSchemaCmd `default:"" cmd:"" help:"Retrieve the cluster FTL schema."` | |||
There was a problem hiding this comment.
We want to preserve this.
There was a problem hiding this comment.
Changed it up so we can preserve it. See the PR description for the new interface.
Or is there a way to get the non-named arg within ftl schema get with kong while maintaining the default cmd for ftl schema? I figured you'd be the expert on that ;)
cmd/ftl/cmd_schema_get.go
Outdated
| if !msg.More { | ||
| break | ||
| } | ||
| } | ||
| for name := range remainingNames { | ||
| fmt.Fprintf(os.Stderr, "module %s not found\n", name) |
There was a problem hiding this comment.
This is not formatted consistently with FTL's CLI, but just return it as an error listing all missing names, and you'll get that for free.
There was a problem hiding this comment.
Oh right it should go to stderr. --protobuf now has the same behaviour
alecthomas
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1090
Allows filtering of schemas to the named modules.
If the input includes a module that was not found, it is returned as an error
The behaviour for these remains the same: